Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station Records: Populate job list whenever possible #1954

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

Populates the job lists and filters for empty stations. Job listings exclude overflow jobs (e.g. contractor, pilot, mercenary on Frontier Outpost), and print out the proper name of the job.

Why / Balance

Being able to set station jobs is important.

How to test

  1. Spawn on Frontier Outpost. Check station records console, all jobs should be listed in their default amounts, with their proper names (Station Traffic Controller, Station Representative), no overflow jobs should be listed (Contractor, Pilot, Mercenary).
  2. Warp to NFSD Outpost. Check station records console, all jobs should be listed in their default amounts, with their proper names (Detective, not DetectiveNF), although no records should be present.
  3. Warp to the Pirate Cove. Check the station records console, all jobs should be listed in their default amounts, with their proper names, although no records should be present.

Media

A picture of the NFSD Outpost, with no valid records.
image

A picture of Frontier Outpost, with no overflow jobs listed.
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: The station records computer should now properly list all jobs whenever possible.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 8, 2024
@dvir001 dvir001 self-requested a review September 14, 2024 15:32
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@dvir001 dvir001 merged commit 753435e into new-frontiers-14:master Sep 14, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 14, 2024
@whatston3 whatston3 deleted the 2024-09-07-station-records-populate branch September 21, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants